Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix scripting errors on Pico's 2hot explosion death #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUGFIX] Fix scripting errors on Pico's 2hot explosion death #97

wants to merge 1 commit into from

Conversation

AbnormalPoof
Copy link
Collaborator

@AbnormalPoof AbnormalPoof commented Oct 31, 2024 •
edited
Loading

PicoPlayerCharacter was using the wrong callback in doExplosionDeath() (onAnimationFinish instead of onAnimationComplete). Furthermore, there wasn't a check to see if deathSpriteRetry wasn't null before accessing it. Which caused a second script error.

Fixes FunkinCrew/Funkin#3182 and FunkinCrew/Funkin#3308

@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. status: pending triage The bug or PR has not been reviewed yet. size: small A small pull request with 10 or fewer changes labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: small A small pull request with 10 or fewer changes status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: 2hot Explosion Death Error
1 participant
@AbnormalPoof